-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<flat_map>: Fix new libcxx test failure due to argument type mismatch when calling ranges::remove_if from flat_map::erase_if
#6017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 5 commits into
microsoft:feature/flat_map
from
vmichal:flat_map-erase_if-const_reference
Jan 16, 2026
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e80fae to
18fbe96
Compare
StephanTLavavej
requested changes
Jan 16, 2026
…as projection argument.
StephanTLavavej
approved these changes
Jan 16, 2026
Member
|
Thanks for figuring out how to fix this! 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly failing libcxx test
std\containers\container.adaptors\flat.multimap\robust_against_nonbool.compile.pass.cppcontains a template lambda written in such a way that template argument deduction fails unless it is called precisely withflat_map::const_referenceSince the predicate given to
flat_map::erase_ifis specified to be callable withflat_map::const_referencein [flat.map.erasure]/2, I think the libcxx test is standards compliant.Adjust the code of
flat_map::erase_ifto satisfy the test.