<functional>: add missed function in move_only_function coverage
#6031
+40
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
commented
Jan 21, 2026
Comment on lines
+206
to
+209
| alloc_checker{is_64_bit ? 0 : 1}, test_wrapped_move_move_call<move_only_function<fn_type>, | ||
| move_only_function<fn_type>, function<fn_type>, small_callable>(0); | ||
| alloc_checker{1}, test_wrapped_move_move_call<move_only_function<fn_type>, move_only_function<fn_type>, | ||
| function<fn_type>, large_callable>(0); |
Contributor
Author
There was a problem hiding this comment.
These two are the essential missed coverage being added.
The rest of the change is the renaming.
StephanTLavavej
approved these changes
Jan 21, 2026
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5808
#5808 added functions that handle moving of
functionthat is wrapped inmove_only_function, the 32-bit and the 64-bit flavor.None of them was actually exercised. It takes another move to exercise these functions.
Also renamed
test_wrapped_calltotest_wrapped_move_callto distinguish it from the futuretest_wrapped_copy_call.Discovered while working on
copyable_functiondraft.