Skip to content

Add static_assert to is_sorted() for the lookup tables in validate.cpp #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbezault merged 1 commit into from
Apr 1, 2020
Merged

Add static_assert to is_sorted() for the lookup tables in validate.cpp #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
cmake_minimum_required(VERSION 3.15)
project(msvc_standard_libraries_tools LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED True)
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

Expand Down
7 changes: 3 additions & 4 deletions tools/validate/validate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,9 @@ int main() {
".gitmodules"sv,
};

// TRANSITION, P0202R3, use constexpr is_sorted()
assert(is_sorted(skipped_directories.begin(), skipped_directories.end()));
assert(is_sorted(skipped_extensions.begin(), skipped_extensions.end()));
assert(is_sorted(tabby_filenames.begin(), tabby_filenames.end()));
static_assert(is_sorted(skipped_directories.begin(), skipped_directories.end()));
static_assert(is_sorted(skipped_extensions.begin(), skipped_extensions.end()));
static_assert(is_sorted(tabby_filenames.begin(), tabby_filenames.end()));

vector<unsigned char> buffer; // reused for performance

Expand Down