#502 update filter driver altitudes with new ones and update any old ones#503
#502 update filter driver altitudes with new ones and update any old ones#503
Conversation
There was a problem hiding this comment.
Pull request overview
Updates SQLNexus’s minifilter altitude handling and lookup data to reflect refreshed Microsoft “Allocated Altitudes” information and to better size the imported altitude columns.
Changes:
- Set explicit
Altitudecolumn length (48) forfltmcrowsets in both TextRowsets.xml copies. - Update existing
filter_driver_altitudesvendor strings and correct a vendor spelling. - Add a new batch of “Allocated Altitudes (2025 refresh)” entries to
filter_driver_altitudesplus a reference link comment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sqlnexus/TextRowsets.xml | Adds explicit NVARCHAR length for Altitude in fltmc rowsets. |
| RowsetImportEngine/TextRowsets.xml | Mirrors the same Altitude length change for the engine copy. |
| sqlnexus/SQLNexus_PostProcessing.sql | Updates and extends the filter_driver_altitudes seed data and adds a documentation link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa') | ||
| ,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa') | ||
| ,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa') |
There was a problem hiding this comment.
Minor consistency: these new Omnissa entries use sys(Renamed) without a space, while other existing rows in this same file use sys (Renamed). For consistency and easier searching/filtering, use the same spacing format as the existing (Renamed) entries.
| ,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa') | |
| ,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa') | |
| ,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa') | |
| ,(N'Top', N'hznprotect.sys (Renamed)', N'400700.5', N'Omnissa') | |
| ,(N'Top', N'hzncdrfilter.sys (Renamed)', N'400700.3', N'Omnissa') | |
| ,(N'Top', N'hznflstor.sys (Renamed)', N'400700', N'Omnissa') |
| INSERT INTO dbo.filter_driver_altitudes | ||
| VALUES | ||
| (N'Top', N'PredaEGSensor.sys', N'400395.5', N'Hunter Team Labs, Inc.') | ||
| ,(N'Top', N'DPEACDrv.sys', N'393000.5', N'Delinea Inc.') | ||
| ,(N'Top', N'hznregreflection.sys', N'400700.7', N'Omnissa') | ||
| ,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa') | ||
| ,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa') | ||
| ,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa') |
There was a problem hiding this comment.
These new Omnissa hzn* rows duplicate altitudes that already exist earlier in this script for VMware (vmwprotect.sys / vmwcdrfilter.sys / vmwflstor.sys at 400700.5 / 400700.3 / 400700). Because later post-processing joins to filter_driver_altitudes on Altitude only, having multiple rows with the same altitude but different companies will cause ambiguous/nondeterministic updates. Prefer updating/replacing the existing VMware rows (or otherwise enforcing one row per altitude) rather than inserting duplicates.
| INSERT INTO dbo.filter_driver_altitudes | |
| VALUES | |
| (N'Top', N'PredaEGSensor.sys', N'400395.5', N'Hunter Team Labs, Inc.') | |
| ,(N'Top', N'DPEACDrv.sys', N'393000.5', N'Delinea Inc.') | |
| ,(N'Top', N'hznregreflection.sys', N'400700.7', N'Omnissa') | |
| ,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa') | |
| ,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa') | |
| ,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa') | |
| -- Note: do not add Omnissa renamed hzn* rows at 400700.5 / 400700.3 / 400700 here, | |
| -- because earlier VMware rows already own those altitudes and later processing joins | |
| -- dbo.filter_driver_altitudes on Altitude only. | |
| INSERT INTO dbo.filter_driver_altitudes | |
| VALUES | |
| (N'Top', N'PredaEGSensor.sys', N'400395.5', N'Hunter Team Labs, Inc.') | |
| ,(N'Top', N'DPEACDrv.sys', N'393000.5', N'Delinea Inc.') | |
| ,(N'Top', N'hznregreflection.sys', N'400700.7', N'Omnissa') |
| ,(N'Content Screener', N'VHDFlt.sys', N'260210', N'Dell') | ||
| ,(N'Quota Management', N'dfx-qfs-fltr.sys', N'245100', N'DefendX Software') | ||
| ,(N'Quota Management', N'dfx-qfs-fltr.sys', N'245100', N'Superna') | ||
| ,(N'Quota Management', N'ntps_qfs.sys', N'245100', N'DefendX Software') |
There was a problem hiding this comment.
filter_driver_altitudes now contains multiple rows with the same Altitude (245100) but different Company values. Because the post-processing updates join tbl_fltmc_* to this lookup table on Altitude only, this creates an ambiguous match and can result in nondeterministic/wrong Company/Minifilter values being written. Either ensure Altitude is unique in filter_driver_altitudes (e.g., update/remove the duplicate) or change the update join to include an additional key (such as minifilter/filter name) so it matches exactly one row.
| ,(N'Quota Management', N'ntps_qfs.sys', N'245100', N'DefendX Software') |
…ones