Skip to content

#502 update filter driver altitudes with new ones and update any old ones#503

Open
PiJoCoder wants to merge 2 commits intomasterfrom
UpdateFilterDrvList_pijocoder_042426
Open

#502 update filter driver altitudes with new ones and update any old ones#503
PiJoCoder wants to merge 2 commits intomasterfrom
UpdateFilterDrvList_pijocoder_042426

Conversation

@PiJoCoder
Copy link
Copy Markdown
Collaborator

…ones

@PiJoCoder PiJoCoder changed the title #502 update filter driver altitudes with new news and update any old … #502 update filter driver altitudes with new news and update any old ones Apr 25, 2026
@PiJoCoder PiJoCoder added this to the Wave 6 milestone Apr 25, 2026
@PiJoCoder PiJoCoder self-assigned this Apr 25, 2026
@PiJoCoder PiJoCoder linked an issue Apr 25, 2026 that may be closed by this pull request
@PiJoCoder PiJoCoder changed the title #502 update filter driver altitudes with new news and update any old ones #502 update filter driver altitudes with new ones and update any old ones Apr 25, 2026
@PiJoCoder PiJoCoder removed the wave 6 label Apr 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates SQLNexus’s minifilter altitude handling and lookup data to reflect refreshed Microsoft “Allocated Altitudes” information and to better size the imported altitude columns.

Changes:

  • Set explicit Altitude column length (48) for fltmc rowsets in both TextRowsets.xml copies.
  • Update existing filter_driver_altitudes vendor strings and correct a vendor spelling.
  • Add a new batch of “Allocated Altitudes (2025 refresh)” entries to filter_driver_altitudes plus a reference link comment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
sqlnexus/TextRowsets.xml Adds explicit NVARCHAR length for Altitude in fltmc rowsets.
RowsetImportEngine/TextRowsets.xml Mirrors the same Altitude length change for the engine copy.
sqlnexus/SQLNexus_PostProcessing.sql Updates and extends the filter_driver_altitudes seed data and adds a documentation link.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +2259 to +2261
,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa')
,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa')
,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa')
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor consistency: these new Omnissa entries use sys(Renamed) without a space, while other existing rows in this same file use sys (Renamed). For consistency and easier searching/filtering, use the same spacing format as the existing (Renamed) entries.

Suggested change
,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa')
,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa')
,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa')
,(N'Top', N'hznprotect.sys (Renamed)', N'400700.5', N'Omnissa')
,(N'Top', N'hzncdrfilter.sys (Renamed)', N'400700.3', N'Omnissa')
,(N'Top', N'hznflstor.sys (Renamed)', N'400700', N'Omnissa')

Copilot uses AI. Check for mistakes.
Comment on lines +2254 to +2261
INSERT INTO dbo.filter_driver_altitudes
VALUES
(N'Top', N'PredaEGSensor.sys', N'400395.5', N'Hunter Team Labs, Inc.')
,(N'Top', N'DPEACDrv.sys', N'393000.5', N'Delinea Inc.')
,(N'Top', N'hznregreflection.sys', N'400700.7', N'Omnissa')
,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa')
,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa')
,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa')
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new Omnissa hzn* rows duplicate altitudes that already exist earlier in this script for VMware (vmwprotect.sys / vmwcdrfilter.sys / vmwflstor.sys at 400700.5 / 400700.3 / 400700). Because later post-processing joins to filter_driver_altitudes on Altitude only, having multiple rows with the same altitude but different companies will cause ambiguous/nondeterministic updates. Prefer updating/replacing the existing VMware rows (or otherwise enforcing one row per altitude) rather than inserting duplicates.

Suggested change
INSERT INTO dbo.filter_driver_altitudes
VALUES
(N'Top', N'PredaEGSensor.sys', N'400395.5', N'Hunter Team Labs, Inc.')
,(N'Top', N'DPEACDrv.sys', N'393000.5', N'Delinea Inc.')
,(N'Top', N'hznregreflection.sys', N'400700.7', N'Omnissa')
,(N'Top', N'hznprotect.sys(Renamed)', N'400700.5', N'Omnissa')
,(N'Top', N'hzncdrfilter.sys(Renamed)', N'400700.3', N'Omnissa')
,(N'Top', N'hznflstor.sys(Renamed)', N'400700', N'Omnissa')
-- Note: do not add Omnissa renamed hzn* rows at 400700.5 / 400700.3 / 400700 here,
-- because earlier VMware rows already own those altitudes and later processing joins
-- dbo.filter_driver_altitudes on Altitude only.
INSERT INTO dbo.filter_driver_altitudes
VALUES
(N'Top', N'PredaEGSensor.sys', N'400395.5', N'Hunter Team Labs, Inc.')
,(N'Top', N'DPEACDrv.sys', N'393000.5', N'Delinea Inc.')
,(N'Top', N'hznregreflection.sys', N'400700.7', N'Omnissa')

Copilot uses AI. Check for mistakes.
,(N'Content Screener', N'VHDFlt.sys', N'260210', N'Dell')
,(N'Quota Management', N'dfx-qfs-fltr.sys', N'245100', N'DefendX Software')
,(N'Quota Management', N'dfx-qfs-fltr.sys', N'245100', N'Superna')
,(N'Quota Management', N'ntps_qfs.sys', N'245100', N'DefendX Software')
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter_driver_altitudes now contains multiple rows with the same Altitude (245100) but different Company values. Because the post-processing updates join tbl_fltmc_* to this lookup table on Altitude only, this creates an ambiguous match and can result in nondeterministic/wrong Company/Minifilter values being written. Either ensure Altitude is unique in filter_driver_altitudes (e.g., update/remove the duplicate) or change the update join to include an additional key (such as minifilter/filter name) so it matches exactly one row.

Suggested change
,(N'Quota Management', N'ntps_qfs.sys', N'245100', N'DefendX Software')

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update filter driver altitudes

2 participants