Allow for PR queries across projects#91
Merged
supermem613 merged 11 commits intomainfrom May 11, 2023
Merged
Conversation
This change implements the basic logic to allow PR queries to be configured for any project. The PR query editor dialog now has a project textbox, and the query is saved with the project context.
Member
|
[like] Vanya Kashperuk reacted to your message:
…________________________________
From: Marcus Markiewicz ***@***.***>
Sent: Wednesday, May 10, 2023 2:05:48 PM
To: microsoft/TeamMate ***@***.***>
Cc: Vanya Kashperuk ***@***.***>; Review requested ***@***.***>
Subject: Re: [microsoft/TeamMate] Allow for PR queries across projects (PR #91)
@supermem613<https://github.com/supermem613> requested your review on: #91<#91> Allow for PR queries across projects.
—
Reply to this email directly, view it on GitHub<#91 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGZ6XFLGQKY4OEKZ3HIE3JDXFOODZANCNFSM6AAAAAAX4ZNNGA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Contributor
Author
|
@ivanv-microsoft , please take a look and sign off when you have a min... |
ivanv-microsoft
approved these changes
May 11, 2023
This was referenced Jan 11, 2024
supermem613
added a commit
that referenced
this pull request
Jan 12, 2024
This is a regression from the PR functionality (#91). We have a cache of graph objects (user and groups) to provide email resolution in query UX. For customers with very large graphs, lo and behold, we tie up a lot of memory. We are going to mitigate the memory usage with two approaches: (1) Instead of caching full graph objects (user and group), let's just cache the data we use. This brings down memory consumption by ~60% on a test machine where there are a lot of objects to cache. (2) We will only load the resolver cache when it is used. If a customer doesn't use PR functionality at all, it would never light up, so we save the bandwidth, CPU, and memory. Compared to 0.1.8, this change yields ~80% memory savings on a machine with lots of graph objects. Overall, this will make the PR feature fully pay-for-play as you won't pay any CPU, network, or memory costs unless you use it. And even when you use it, we will use a lot less memory (~60% less in my tests). Also tested with PR queries and observed the on-demand querying happening. All async and not blocking any UI threads as it was previously. Fixes #100.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a number of cases, PRs happen in a different project than Work Items. This makes it cumbersome to use TeamMate as you'd have to keep flipping the active project.
With this change, we will allow for setting PR queries against any of the connected projects.
We then extend the PR queries to allow for any CreatedBy or AssignedTo based on emails.