Skip to content

Fix nuget packages#186

Merged
spebl merged 4 commits into
dev15from
dev/trlabell/fix-nuget-packages
Jan 27, 2021
Merged

Fix nuget packages#186
spebl merged 4 commits into
dev15from
dev/trlabell/fix-nuget-packages

Conversation

@tristanlabelle
Copy link
Copy Markdown

Nuget packages could not be restored after a myget feed has been taken down. This attempts to use the nuget.org versions of these packages. This is untested, I'm relying on the build pipeline.

<EmbeddedResource Include="Resources\ReleaseNotes\0.5.1.md" />
<EmbeddedResource Include="Resources\ReleaseNotes\0.1.0.md" />
<EmbeddedResource Include="Resources\ReleaseNotes\0.2.0.md" />
<EmbeddedResource Include="Resources\ReleaseNotes\0.4.1.md" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runaway find-and-replace :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Especially since that built without issues.

@spebl
Copy link
Copy Markdown

spebl commented Jan 27, 2021

Looked into why this was still failing in microbuild and found one small version mismatch for tafgt (our flavor we build). Pushed a small change that should fix this. Thanks for the initial work @MrTrillian!

@tristanlabelle
Copy link
Copy Markdown
Author

@spebl This change is a bit speculative. If it works, great! Otherwise, we might have to pick up the update from the source repo that removed the dependency on TestWindow. There are notes in the comments on our internal bug.

@spebl
Copy link
Copy Markdown

spebl commented Jan 27, 2021

Yes, sounds good. Verified this will fix the build which should unblock applying the other patch Ben has a PR up for.

@spebl spebl self-requested a review January 27, 2021 22:26
@spebl spebl merged commit 66aeffc into dev15 Jan 27, 2021
@bobbrow bobbrow deleted the dev/trlabell/fix-nuget-packages branch November 25, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants