Fix debugging from test explorer & don't attach to testhost.exe#190
Merged
Conversation
This reverts commit 921b040.
…the testwindow exports there
Author
|
@microsoft/vcls Can anyone take a look at this? Quite small but important changes :) |
|
What is the mentioned bug? |
Author
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1218918/
|
tristanlabelle
approved these changes
Apr 6, 2021
tristanlabelle
left a comment
tristanlabelle
left a comment
There was a problem hiding this comment.
Looks good! I'd just suggest not leaving TODOs in the code as it's not an efficient way to track work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there is no option to attach to testhost.exe if wanted, as there does not seem to be any value in that as per the bug. This also includes a fix to make sure we don't try to deploy the vsix when building which breaks the CI build now since moving to the new resource pool.