Skip to content

Add overrides to Node & NamedNodeMap interfaces #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsifford wants to merge 1 commit into from
Closed

Add overrides to Node & NamedNodeMap interfaces #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8168,13 +8168,13 @@ declare var MutationRecord: {

interface NamedNodeMap {
readonly length: number;
getNamedItem(name: string): Attr;
getNamedItemNS(namespaceURI: string | null, localName: string | null): Attr;
item(index: number): Attr;
getNamedItem(name: string): Attr | null;
getNamedItemNS(namespaceURI: string | null, localName: string | null): Attr | null;
item(index: number): Attr | null;
removeNamedItem(name: string): Attr;
removeNamedItemNS(namespaceURI: string | null, localName: string | null): Attr;
setNamedItem(arg: Attr): Attr;
setNamedItemNS(arg: Attr): Attr;
setNamedItem(arg: Attr): Attr | null;
setNamedItemNS(arg: Attr): Attr | null;
[index: number]: Attr;
}

Expand Down Expand Up @@ -8242,7 +8242,7 @@ declare var Navigator: {
interface Node extends EventTarget {
readonly attributes: NamedNodeMap;
readonly baseURI: string | null;
readonly childNodes: NodeList;
readonly childNodes: NodeListOf<Node & ChildNode>;
readonly firstChild: Node | null;
readonly lastChild: Node | null;
readonly localName: string | null;
Expand Down
47 changes: 47 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,5 +1389,52 @@
"interface": "ServiceWorkerContainer",
"name": "getRegistration",
"signatures": ["getRegistration(): Promise<ServiceWorkerRegistration | undefined>"]
},
{
"kind": "method",
"interface": "NamedNodeMap",
"name": "getNamedItem",
"signatures": [
"getNamedItem(name: string): Attr | null"
]
},
{
"kind": "method",
"interface": "NamedNodeMap",
"name": "getNamedItemNS",
"signatures": [
"getNamedItemNS(namespaceURI: string | null, localName: string | null): Attr | null"
]
},
{
"kind": "method",
"interface": "NamedNodeMap",
"name": "item",
"signatures": [
"item(index: number): Attr | null"
]
},
{
"kind": "method",
"interface": "NamedNodeMap",
"name": "setNamedItem",
"signatures": [
"setNamedItem(arg: Attr): Attr | null"
]
},
{
"kind": "method",
"interface": "NamedNodeMap",
"name": "setNamedItemNS",
"signatures": [
"setNamedItemNS(arg: Attr): Attr | null"
]
},
{
"kind": "property",
"interface": "Node",
"readonly": true,
"name": "childNodes",
"type": "NodeListOf<Node & ChildNode>"
}
]