Skip to content

Fix Microsoft/TypeScript#19277 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kingwl wants to merge 1 commit into from
Closed

Fix Microsoft/TypeScript#19277 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2705,7 +2705,7 @@ interface Document extends Node, GlobalEventHandlers, NodeSelector, DocumentEven
/**
* Contains information about the current URL.
*/
readonly location: Location;
location: Location | string;
msCapsLockWarningOff: boolean;
msCSSOMElementFloatMetrics: boolean;
/**
Expand Down Expand Up @@ -13112,7 +13112,7 @@ interface Window extends EventTarget, WindowTimers, WindowSessionStorage, Window
readonly innerWidth: number;
readonly isSecureContext: boolean;
readonly length: number;
readonly location: Location;
location: Location | string;
readonly locationbar: BarProp;
readonly menubar: BarProp;
readonly msContentScript: ExtensionScriptApis;
Expand Down Expand Up @@ -14515,7 +14515,7 @@ declare var innerHeight: number;
declare var innerWidth: number;
declare var isSecureContext: boolean;
declare var length: number;
declare var location: Location;
declare var location: Location | string;
declare var locationbar: BarProp;
declare var menubar: BarProp;
declare var msContentScript: ExtensionScriptApis;
Expand Down
12 changes: 12 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@
"name": "currentScript",
"type": "HTMLScriptElement | SVGScriptElement | null"
},
{
"kind": "property",
"interface": "Document",
"name": "location",
"type": "Location | string"
},
{
"kind": "method",
"interface": "Document",
Expand Down Expand Up @@ -986,6 +992,12 @@
"name": "opener",
"type": "any"
},
{
"kind": "property",
"interface": "Window",
"name": "location",
"type": "Location | string"
},
{
"kind": "method",
"interface": "History",
Expand Down