Skip to content

Conversation

@jakearchibald
Copy link
Contributor

I'm not entirely sure what I'm doing, but if I've done this right it fixes microsoft/TypeScript#22565 - a regression created in #383 (comment).

@msftclas
Copy link

msftclas commented Mar 26, 2018

CLA assistant check
All CLA requirements met.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 26, 2018

you also need to include the new baselines. just run npm run baseline-accept after npm run build

Previously this wasn't copying anything, on OSX at least.
@jakearchibald
Copy link
Contributor Author

Done. I also fixed the baseline-accept script, which didn't do anything (on OSX at least).

@mhegazy mhegazy merged commit a8b2756 into microsoft:master Mar 27, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Mar 27, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(event: TouchEvent) => void is not assignable "touchstart" event.

3 participants