fix: UMD should be specified in moduleResolution default #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's mentioned in the TSConfig Reference, but not in Compiler Options, so ensure the two align - also use similar grammar in the TSConfig Reference as in Compiler Options as I thought this was easier to read this way
|
|
orta
approved these changes
Sep 18, 2020
Contributor
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
I'm not sure what started triggering the CLA, but this is looks good to me 👍🏻
Contributor
Author
|
Yea I was like "this isn't my first PR... 🤔 🤔 ". Signed now |
Contributor
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it's mentioned in the TSConfig Reference, but not in Compiler Options,
so ensure the two align
also use similar grammar in the TSConfig Reference as in Compiler
Options as I thought this was easier to read this way
Tags
Similar to #1110 , #1102, and #1101 , found while investigating discrepancies between the TSConfig Reference and Compiler Options after finding #1092
Review Notes
Similar to #1110, have not tested this myself to know which one is correct.
Also feel free to reject the Reference grammar change or let me know if you want the wording to be different in either.
Phew, this will be my last PR for a bit...