Fix accessibility issue for css variable highlight#2844
Merged
jakebailey merged 1 commit intomicrosoft:v2from May 31, 2023
Merged
Fix accessibility issue for css variable highlight#2844jakebailey merged 1 commit intomicrosoft:v2from
jakebailey merged 1 commit intomicrosoft:v2from
Conversation
navya9singh
approved these changes
May 31, 2023
jakebailey
added
the
deploy-preview
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2844.centralus.azurestaticapps.net |
Member
Author
|
Works:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2840
We wasted a bunch of time testing this before I stumbled on the problem that there's some cache somewhere that duplicates this theme, such that changing it didn't actually work. Cleaning the repo and reinstalling/rebuilding/etc actually shows that changing this does work.
This color upstream is https://github.com/shikijs/shiki/blob/main/packages/shiki/themes/light-plus.json#L294 (the same as what the accessibility team/tool say to use).