Disable playground plugin script in bootstrap#3122
Merged
jakebailey merged 1 commit intomicrosoft:v2from May 23, 2024
Merged
Conversation
navya9singh
approved these changes
May 23, 2024
Member
Author
|
Then again, builds are already non-deterministic thanks to the releases. Maybe I do just gitignore it. |
Member
Author
|
Eh, let's just do this for now to unblock other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script changes the list of plugins on bootstrap into a committed file, which causes differences when building. This is annoying for local dev, but also fails CI because I made it error on file diffs like that.
The fixes could be:
I'm going to opt for the latter for now. There do not seem to be new plugins being created these days. We can manually rerun the script later or figure something better out.