`#region` not always folding

[mhegazy]

// #region label1
var x;
// #endregion label1 

Actual:

Note: I got these from tests\cases\fourslash\getOutliningSpansForRegions.ts, so seems like the test is not testing the right thing.

[uniqueiniquity]

@mhegazy When stepping through the test, it is actually testing the right thing. Seems that the regex match works in mocha but not otherwise. I can easily fix the issue in general, but am concerned that we don't know what changed. (@DanielRosenwasser)

[mhegazy]

not sure i follow.. so the test is working correctly? if so why is it failing for VS/VSCode?

[uniqueiniquity]

There seems to be a difference in the way line endings are handled in mocha and otherwise. When attaching a debugger to tsserver, I can see that the regex is failing on the string "// #region label1\r", which is clearly my mistake, I should have handled line endings better. But when attaching a debugger to the mocha test, it reads the string as "// #region label1" and passes fine.

[mhegazy]

I see. thanks for the explanation. that is something we need to fix as well to make sure we are testing the something that happens in the server. i would make that a different issue. let's fix the original issue first though.