factory.updateModifiers should be part of NodeFactory public api

[FranklinWhale]

Suggestion

🔍 Search Terms

node, modifiers, update, updateModifiers

✅ Viability Checklist

My suggestion meets these guidelines:

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
• This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Currently modifying the modifiers for different types of nodes is a bit complicated because each type of nodes has its own update method provided by the factory. The factory already has a updateModifiers method; it is just not public.

📃 Motivating Example

https://stackoverflow.com/questions/65075866/typescript-compiler-api-how-to-add-remove-modifier-from-statement

💻 Use Cases

Allow API user to update any node with modifiers using the same method

[rbuckton]

I've considered this. The only reason I haven't made it public is that I've been considering alternative approaches to updating common node properties like name, parameters, body, and type, without essentially duplicating updateModifiers for each case, so I did not feel the API endpoint was stable for public consumption as it was likely to change.