"Move to file" carries forward imports to target file

[DanielRosenwasser]

Here's hello.ts:

import { World } from "./world";

export function getHello() {
    return "hello";
}

export function getWorld(): World {
    return "world";
}

Here's world.ts

export type World = "world";

Here's what "move to file" will generate to world.ts:

import { World } from "./world";

export type World = "world";export function getWorld(): World {
    return "world";
}

Notice that the import for World is brought over to the target file.

[fatcerberus]

Isn’t this incorrect only because you’re moving the function into the file containing the type(s) it needs? (I only ask because the issue title suggests bringing over imports is wrong in general)

[DanielRosenwasser]

Yes, though it's not just types, and it's not an uncommon scenario.

[fatcerberus]

Yeah, I didn’t mean to imply it wasn’t an issue - just that the issue title (and to some extent, the issue text) suggests the problem is carrying forward imports at all, when in reality it’s just if the target file already contains the thing being imported.

[RyanCavanaugh]

I think this got fixed alongside the other one