Follow up on #16223 cleaning up Array declarations #18116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Aug 30, 2017
src/lib/es2015.core.d.ts
Outdated
| find(predicate: (this: void, value: T, index: number, obj: Array<T>) => boolean): T | undefined; | ||
| find(predicate: (this: void, value: T, index: number, obj: Array<T>) => boolean, thisArg: undefined): T | undefined; | ||
| find<Z>(predicate: (this: Z, value: T, index: number, obj: Array<T>) => boolean, thisArg: Z): T | undefined; | ||
| find(predicate: (this: void, value: T, index: number, obj: Array<T>) => boolean, thisArg?: any): T | undefined; |
There was a problem hiding this comment.
Do we need the this: void? It's not actually accurate because if a thisArg is passed, then this won't be void.
If someone really does want to pass thisArg, this: void would stop them, but if this: void is ommitted, they will correctly get an error in --noImplicitThis mode, and can work around it by explicitly annotating a this type for their callback.
declare function f(cb: (this: void) => void, thisArg?: any): void;
declare function g(cb: () => void, thisArg?: any): void;
// Can't get a correct type for `this`, even with explicit annotation
f(function(this: string) {
this.toLowerCase();
}, "");
// Works
g(function(this: string) {
this.toLowerCase();
}, "");
Contributor
Author
There was a problem hiding this comment.
thanks. should be fixed now.
ghost
approved these changes
Aug 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed some methods in #16223, also coalescing
Array.fromsignatures using generic defaults.