Skip to content

Add Object.getOwnPropertyDescriptors definition (2nd attempt) #18175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 1 commit into from
Sep 7, 2017
Merged

Add Object.getOwnPropertyDescriptors definition (2nd attempt) #18175

mhegazy merged 1 commit into from
Sep 7, 2017

Conversation

@taras
Copy link
Contributor

@taras taras commented Aug 31, 2017

@msftclas
Copy link

msftclas commented Aug 31, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ikatyang
Copy link
Contributor

ikatyang commented Aug 31, 2017

These files are not meant to be edited by hand. If you need to make modifications, the respective files should be changed within the repository's top-level src directory. Running jake LKG will then appropriately update the files in this directory. (https://github.com/Microsoft/TypeScript/tree/master/lib#readme)

-> https://github.com/Microsoft/TypeScript/tree/master/src/lib#readme

@taras
Copy link
Contributor Author

taras commented Aug 31, 2017

@ikatyang I didn't realize that this was the case. I added it to src directory and built. The build modified lots of files but I only committed the 2 that are relevant to this commit.

@taras
Copy link
Contributor Author

taras commented Aug 31, 2017

@ikatyang ready to go

mhegazy
mhegazy reviewed Aug 31, 2017
View reviewed changes
lib/lib.es2017.object.d.ts Outdated
* Returns an object containing all own property descriptors of an object
* @param o Object that contains the properties and methods. This can be an object that you created or an existing Document Object Model (DOM) object.
*/
getOwnPropertyDescriptors<T>(o: T): {[P in keyof T]: TypedPropertyDescriptor<T[P]>} & { [x: string]: PropertyDescriptor };
Copy link
Contributor

@mhegazy mhegazy Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert changes to this file. this file is generated from src/lib/es2017.object.d.ts

@taras
Copy link
Contributor Author

taras commented Sep 1, 2017

@mhegazy I made the change that you requested.

@mhegazy mhegazy merged commit 59aa29b into microsoft:master Sep 7, 2017
@mhegazy mhegazy mentioned this pull request Sep 21, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taras @msftclas @ikatyang @mhegazy