Debug.failBadSyntaxKind should always be defined and return 'never' #22091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
failBadSyntaxKind
branch
from
9fe017f to
81dbf77
Compare
ghost
mentioned this pull request
rbuckton
approved these changes
Mar 27, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places we need to ensure that a function returns, so we call
Debug.failBadSyntaxKindin a default case. But if that function is not defined we will just fall through and returnundefined(which breaks in #22088). This is an unconditional failure rather than an assertion, so I don't think it hurts performance to remove theAssertionLevelcheck.