add spelling suggestion support for module import #22283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
approved these changes
Mar 2, 2018
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
Looks good!
As a follow-up for a separate PR, I think it would be ideal to see if we could make the quick-fix here actually fix up all local references to this import within the module. I'll file that separately after this goes in.
src/compiler/checker.ts
Outdated
| error(name, Diagnostics.Module_0_has_no_exported_member_1, getFullyQualifiedName(moduleSymbol), declarationNameToString(name)); | ||
| const suggestion = getSuggestionForNonexistentModule(name, targetSymbol); | ||
| if (suggestion !== undefined) { | ||
| error(name, Diagnostics.Module_0_has_no_exported_member_1_Did_you_mean_2, getFullyQualifiedName(moduleSymbol), declarationNameToString(name), suggestion); |
Member
There was a problem hiding this comment.
Maybe move the first two arguments out of each call to error to avoid the duplication in logic.
sandersn
approved these changes
Mar 2, 2018
sandersn
reviewed
Mar 2, 2018
| return result && symbolName(result); | ||
| } | ||
|
|
||
| function getSuggestionForNonexistentModule(name: Identifier, targetModule: Symbol): string | undefined { |
Member
There was a problem hiding this comment.
one small nit: getSuggestionForNonexistentExport might be a better name. Not sure if it's worth changing through.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21875