annotateWithTypeFromJSDoc: Use changes.insertTypeAnnotation instead of replaceNode #22404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
sandersn
approved these changes
Mar 8, 2018
ghost
mentioned this pull request
amcasey
reviewed
Mar 8, 2018
| `class C { | ||
| /** @return {number} */ | ||
| get c(): number { return 12; } | ||
| get c(): number { return 12 } |
Author
There was a problem hiding this comment.
There's no semicolon in the original (line 4 of this file). Previously we would reformat the body, but now we just add a type annotation.
| return getJSDocType(node); | ||
| } | ||
| export function getEffectiveTypeAnnotationNode(node: Node): TypeNode | undefined { | ||
| return (node as HasType).type || (isInJavaScriptFile(node) ? getJSDocType(node) : undefined); |
Member
There was a problem hiding this comment.
For my own understanding, if node is not a HasType but does have a type property with a defined value, we will return that (as we did before?)?
Author
There was a problem hiding this comment.
Yes, the assumption is that only a HasType has a type.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22358