inferFromUsage: Handle being at an unexpected location #22569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
amcasey
approved these changes
Mar 14, 2018
Member
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
I'd be surprised to learn this is the only consequence of being given an unexpected location, but I see nothing inherently wrong with this change. A comment might help though.
Author
|
See #21607 (comment) (and microsoft/vscode#45785) |
mhegazy
pushed a commit
that referenced
this pull request
Mar 28, 2018
* inferFromUsage: Handle being at an unexpected location * add comment
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #22481 -- occasionally we get a bad request from the editor and the location isn't at an actual error location.