Alternate but more general token comment emit fix + organizeImports fix #22836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
force-pushed
the
check-emit-position-for-positional-comments
branch
from
5aa3a69 to
4b63c3c
Compare
ghost
approved these changes
Mar 23, 2018
@amcasey: Preserve leading trivia when organizing imports When organizing imports, we used to move the leading and trailing trivia of each individual import with that import as it was repositioned or deleted. This had the unfortunate effect of repositioning or deleting the header comment of the file. Our new approach is to leave the leading trivia of the first import ahead of the resulting block of imports (i.e. it no longer follows the first import as it is repositioned or deleted). Trailing trivia on the first import and trivia on subsequent imports are treated as before.
amcasey
approved these changes
Mar 23, 2018
Member
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
Thanks! This is much better. Please just make sure to include my description of the original issue & fix.
weswigham
force-pushed
the
check-emit-position-for-positional-comments
branch
from
4b63c3c to
be85343
Compare
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Mar 23, 2018
…ix (microsoft#22836) @amcasey: Preserve leading trivia when organizing imports When organizing imports, we used to move the leading and trailing trivia of each individual import with that import as it was repositioned or deleted. This had the unfortunate effect of repositioning or deleting the header comment of the file. Our new approach is to leave the leading trivia of the first import ahead of the resulting block of imports (i.e. it no longer follows the first import as it is repositioned or deleted). Trailing trivia on the first import and trivia on subsequent imports are treated as before.
weswigham
added a commit
that referenced
this pull request
Mar 26, 2018
…ix (#22836) (#22840) @amcasey: Preserve leading trivia when organizing imports When organizing imports, we used to move the leading and trailing trivia of each individual import with that import as it was repositioned or deleted. This had the unfortunate effect of repositioning or deleting the header comment of the file. Our new approach is to leave the leading trivia of the first import ahead of the resulting block of imports (i.e. it no longer follows the first import as it is repositioned or deleted). Trailing trivia on the first import and trivia on subsequent imports are treated as before.
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I talked over our current comment emit state with @rbuckton for a bit, and I'm pretty sure this is the right way to fix the issue until a more comprehensive system is in place.
Alternative to #22832.
Fixes #22831
Fixes #22723
Fixes #22724
Fixes #22731