Skip to content

Conversation

@uniqueiniquity
Copy link
Contributor

This is generally cleanup, so not wholly necessary for TS 3.1.

  • Remove unnecessary call to concat on a ReadonlyArray to convert to a mutable array
  • Clarify meaning of when an argName is set as undefined
  • Add test demonstrating when undefined is passed to catch
  • Narrow annotated type
  • Rename function to point out that a default value is produced

@uniqueiniquity uniqueiniquity requested review from a user and amcasey September 18, 2018 16:37
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@uniqueiniquity uniqueiniquity merged commit cd28af0 into microsoft:master Sep 18, 2018
@uniqueiniquity uniqueiniquity deleted the miscAsyncFixes branch September 18, 2018 17:53
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants