Skip to content

Conversation

@sandersn
Copy link
Member

Note that projectId is not included in the metadata. It should be, but marked as excluded, I believe. I need to ask @kieferrm whether vscode-gdpr-tooling needs to add support for this combination.

@sandersn sandersn requested a review from amcasey September 19, 2018 16:38
}

/* __GDPR__
"typingsinstalled" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might also be a version property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where? I thought the properties only came from the interface itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For the other comment as well.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this doesn't work right now. Filed Microsoft/vscode-gdpr-tooling#6 to track. I think I'll merge this anyway since we have existing metadata to fall back on.

@amcasey
Copy link
Member

amcasey commented Sep 19, 2018

I think it might be helpful to link to the comment tool repo in the commit message.

@sandersn sandersn merged commit 80045ca into master Sep 19, 2018
@sandersn
Copy link
Member Author

I'll follow up with actions for projectId and TypeScriptCommonProperties when I hear back from @kieferrm

@sandersn sandersn deleted the add-gdpr-annotations branch August 26, 2019 17:32
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants