Skip to content

Fix checking for type parameter visibility when merged with a parameter #27444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 1 commit into from
Oct 2, 2018
Merged

Fix checking for type parameter visibility when merged with a parameter #27444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,7 +1231,7 @@ namespace ts {
// local types not visible outside the function body
: false;
}
if (meaning & SymbolFlags.Value && result.flags & SymbolFlags.FunctionScopedVariable) {
if (meaning & result.flags & SymbolFlags.FunctionScopedVariable) {
// parameters are visible only inside function body, parameter list and return type
// technically for parameter list case here we might mix parameters and variables declared in function,
// however it is detected separately when checking initializers of parameters
Expand Down
4 changes: 4 additions & 0 deletions tests/baselines/reference/typeParameterDoesntBlockParameterLookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
//// [typeParameterDoesntBlockParameterLookup.ts]
declare function f<Foo extends Bar, Bar>(Bar: any): void

//// [typeParameterDoesntBlockParameterLookup.js]
8 changes: 8 additions & 0 deletions tests/baselines/reference/typeParameterDoesntBlockParameterLookup.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
=== tests/cases/compiler/typeParameterDoesntBlockParameterLookup.ts ===
declare function f<Foo extends Bar, Bar>(Bar: any): void
>f : Symbol(f, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 0))
>Foo : Symbol(Foo, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 19))
>Bar : Symbol(Bar, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 35), Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 41))
>Bar : Symbol(Bar, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 35), Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 41))
>Bar : Symbol(Bar, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 35), Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 41))

5 changes: 5 additions & 0 deletions tests/baselines/reference/typeParameterDoesntBlockParameterLookup.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
=== tests/cases/compiler/typeParameterDoesntBlockParameterLookup.ts ===
declare function f<Foo extends Bar, Bar>(Bar: any): void
>f : <Foo extends Bar, Bar>(Bar: any) => void
>Bar : any

1 change: 1 addition & 0 deletions tests/cases/compiler/typeParameterDoesntBlockParameterLookup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare function f<Foo extends Bar, Bar>(Bar: any): void