Skip to content

Make the assignability rule for conditional types require the check types and distributivity to be identical. #27697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RyanCavanaugh merged 1 commit into from
Feb 11, 2019
Merged

Make the assignability rule for conditional types require the check types and distributivity to be identical. #27697

RyanCavanaugh merged 1 commit into from
Feb 11, 2019

Conversation

@mattmccutchen
Copy link
Contributor

@mattmccutchen mattmccutchen commented Oct 10, 2018

Fixes #27118.

@mattmccutchen mattmccutchen mentioned this pull request Oct 10, 2018
Open
@mattmccutchen
Copy link
Contributor Author

mattmccutchen commented Oct 10, 2018 •
edited
Loading

@typescript-bot test this

I'm not even worthy of a rejection notice from the typescript-bot. ☹️

@weswigham
Copy link
Member

weswigham commented Oct 17, 2018

@typescript-bot test this

He only responds to a MS org member/project owner's hails.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 17, 2018 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at bc9b6d5. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Jan 24, 2019

@typescript-bot test this again

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2019 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at bc9b6d5. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh RyanCavanaugh self-assigned this Jan 24, 2019
@mattmccutchen
Copy link
Contributor Author

mattmccutchen commented Feb 9, 2019

Updated to master. This should remove the unrelated RWC differences.

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Feb 10, 2019

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2019 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 1aca1dd. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Feb 11, 2019

RWC is green! 🎉

@RyanCavanaugh RyanCavanaugh merged commit 2dfb620 into microsoft:master Feb 11, 2019
@ahejlsberg ahejlsberg mentioned this pull request Feb 13, 2019
Merged
@jack-williams jack-williams mentioned this pull request Feb 27, 2019
Closed
4 tasks
sandersn added a commit that referenced this pull request Feb 27, 2019
@sandersn
Revert "Merge pull request #27697 from mattmccutchen/issue-27118"
aedffe0 
This reverts commit 2dfb620, reversing
changes made to bbf559b.
sandersn added a commit that referenced this pull request Feb 27, 2019
@sandersn
Merge pull request #30133 from Microsoft/revert-conditional-type-inva…
0d93eb9 
…riance

Revert "Merge pull request #27697 from mattmccutchen/issue-27118"
@jack-williams jack-williams mentioned this pull request Feb 28, 2019
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@RyanCavanaugh RyanCavanaugh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattmccutchen @weswigham @typescript-bot @RyanCavanaugh