Skip to content

Remove unused property ParameterInference#typeNode #28115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Oct 26, 2018
Merged

Remove unused property ParameterInference#typeNode #28115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/services/codefixes/inferFromUsage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,9 @@ namespace ts.codefix {
}

interface ParameterInference {
declaration: ParameterDeclaration;
type?: Type;
typeNode?: TypeNode;
isOptional?: boolean;
readonly declaration: ParameterDeclaration;
readonly type?: Type;
readonly isOptional?: boolean;
}

namespace InferFromReference {
Expand Down Expand Up @@ -309,7 +308,7 @@ namespace ts.codefix {
}
const isConstructor = declaration.kind === SyntaxKind.Constructor;
const callContexts = isConstructor ? usageContext.constructContexts : usageContext.callContexts;
return callContexts && declaration.parameters.map((parameter, parameterIndex) => {
return callContexts && declaration.parameters.map((parameter, parameterIndex): ParameterInference => {
Copy link
Author

@ghost ghost Oct 24, 2018 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return types don't get a contextual type. (Is there an issue for that?) This made it look like isOptional was unused. Currently it's write-only but that should change in #27978.

const types: Type[] = [];
const isRest = isRestParameter(parameter);
let isOptional = false;
Expand Down