Redo resolution on ATA when previous resolution was to '.js' file #28236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| const commander = { | ||
| path: cachePath + "/node_modules/@types/commander/index.d.ts", | ||
| content: "export let y: string" | ||
| const commanderJS: TestFSWithWatch.File = { |
Member
There was a problem hiding this comment.
I think you should add this as a separate test case (to ensure it keeps working when there is no resolution as one test case while when resolution is to js file as another test case)
sheetalkamat
approved these changes
Oct 30, 2018
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27302
A good way to repro the issue was described in #27347 (comment)