Skip to content

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Feb 19, 2019

  1. Mocha updated and no longer ships a ms implementation itself, instead it uses the ms package. Now we do in our mocha output, too. In addition, it now only sets up the hooks for generate a .stats object in its .run method (which we don't call, as it sets up a bunch of things we don't need or want), so we need to initialize stats generation ourselves.

  2. Seems like Remove diagnostic dependent output in structuredTypeRelatedTo #29817 was opened during the period where we weren't self-testing on CI 😢 This fixes the new strict function type errors identified in watchUtilities by that change (which previously went silently unheard due to the structural fallback & diagnostic-mode dependence of the check!).

@weswigham weswigham merged commit ee17915 into microsoft:master Feb 19, 2019
@weswigham weswigham deleted the fix-strict-errors-in-watchUtilities branch February 19, 2019 22:31
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants