Handle recursive symlinks when matching file names #30376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
RyanCavanaugh,
rbuckton,
sandersn and
weswigham
sandersn
approved these changes
Mar 13, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One naming suggestion, I thought 'realpath' was a little confusing.
| addOrDeleteFile, | ||
| clearCache | ||
| clearCache, | ||
| realpath: host.realpath && realpath |
Member
There was a problem hiding this comment.
maybe this should be called targetpath? I can't tell if it's completely new with this PR or not.
Member
Author
There was a problem hiding this comment.
that's the existing method on system and other hosts like compiler host.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28842