allow literan enum const assertions #30700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Apr 2, 2019
src/compiler/diagnosticMessages.json
Outdated
| "code": 1354 | ||
| }, | ||
| "A 'const' assertion can only be applied to a string, number, boolean, array, or object literal.": { | ||
| "A 'const' assertion can only be applied to a string, number, boolean, array, literal enum, or object literal.": { |
Member
There was a problem hiding this comment.
Maybe "enum member" instead of "literal enum"? I don't think most people would think of A.b as a "literal" of some kind, much as we often treat it like one.
Contributor
Author
There was a problem hiding this comment.
What about "member of literal enum"? "enum member" is also weird and cannot explain that why some enum cannot be used
BTW: Honestly, I don't know the kind of enum before.
Member
There was a problem hiding this comment.
'const' assertions can only be applied to references to enum members, or string, number, boolean, array, or object literals.
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30690