Skip to content

Allow infer type variables to have constraints inferred #32093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weswigham merged 4 commits into from
Jan 25, 2020
Merged

Allow infer type variables to have constraints inferred #32093

weswigham merged 4 commits into from
Jan 25, 2020

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Jun 25, 2019

And allow the breakdown of substitutes in simplifiable source inferences.

Fixes #31736

@weswigham weswigham mentioned this pull request Jun 25, 2019
Closed
@weswigham
Copy link
Member Author

weswigham commented Jun 25, 2019

@typescript-bot run dt
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 25, 2019 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at 25d4aa0. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 25, 2019 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 25d4aa0. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Allow infer type variables to have constraints infered and allow th…
22db82d 
…e breakdown of substitutes in simplifiable source inferences
@weswigham weswigham force-pushed the conditional-constraint-finding branch from 25d4aa0 to 22db82d Compare July 1, 2019 20:36
@weswigham
Copy link
Member Author

weswigham commented Jul 1, 2019

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 1, 2019 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 22db82d. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Member Author

weswigham commented Aug 2, 2019

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2019 •
edited
Loading

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 8f9edd2. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2019 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at 8f9edd2. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2019 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 8f9edd2. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot typescript-bot mentioned this pull request Aug 2, 2019
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2019

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Still skip conditional inference when extends infer Q so such a pat…
9071a92 
…tern still acts as a constraint size breaker
@weswigham weswigham force-pushed the conditional-constraint-finding branch from 5caf18a to 9071a92 Compare August 2, 2019 21:45
@weswigham
Copy link
Member Author

weswigham commented Aug 2, 2019

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 2, 2019 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 9071a92. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham weswigham mentioned this pull request Aug 16, 2019
Closed
5 tasks
@jack-williams jack-williams mentioned this pull request Oct 20, 2019
Closed
@ahejlsberg
Copy link
Member

ahejlsberg commented Jan 24, 2020

Maybe merge with master and re-run the tests.

@weswigham
Copy link
Member Author

weswigham commented Jan 24, 2020

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2020 •
edited
Loading

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 274a9e7. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2020 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at 274a9e7. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 24, 2020 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 274a9e7. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Member Author

weswigham commented Jan 24, 2020

@ahejlsberg all the tests are good. RWC is repeating a no-diff error that's in master (which I just put up and merged a change to fix), user baselines are some no-diff build issues in some docker builds that I have a PR up to fix (due to a break in npm's behavior) and am investigating the last of which with the azure-sdk folks (since it seems to be a 'nix specific issue that might be related to the other one), and the DT failures are the same EventEmitter problems that we can see in master.

So everything looks great!

@weswigham weswigham merged commit 18cd79e into microsoft:master Jan 25, 2020
@weswigham weswigham deleted the conditional-constraint-finding branch January 25, 2020 00:59
ahejlsberg added a commit that referenced this pull request Dec 6, 2020
@ahejlsberg
Undo changes from #32093
7b7b03a
@ahejlsberg ahejlsberg mentioned this pull request Dec 6, 2020
Merged
ahejlsberg added a commit that referenced this pull request Dec 8, 2020
@ahejlsberg
Preserve substitution types in check position of conditional types (#…
646f5b3 
…41841)

* Preserve substitution types in check types of conditional types

* Undo changes from #32093

* Add regression tests

* Accept new baselines
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ahejlsberg ahejlsberg ahejlsberg approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@weswigham weswigham

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3.5.1 regression in mapped types on tuples

3 participants

@weswigham @typescript-bot @ahejlsberg