-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Support template literals in preProcess (fixes #33680) #33688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support template literals in preProcess (fixes #33680) #33688
Conversation
|
Thanks for the PR! It looks like you've changed 'preProcess.ts' in some way. Please ensure that any changes here don't break consumers with unique project systems such as Visual Studio. Pinging @sheetalkamat, @amcasey, and @minestarks so they are aware of the changes. |
07759c8 to
b216757
Compare
|
references #36546 |
|
I closed/re-opened the PR to re-run tests, just to see whether tests still pass after sitting for 6 months. |
|
Should I rebase on top of |
|
It would be nice -- I didn't know you were still paying attention to this PR @IllusionMH! |
b216757 to
15de3ad
Compare
|
Rebased. Sorry for delay - local test/lint took 28mins
I didn't know when/if it will be reviewed/merged, so decided to avoid unnecessary notification spam on pushes. |
|
(I treat no-notifications as a feature so I can move things around all over the place without spamming people.) |
|
Everything but node 10 and node 8 on Travis is done, so I'm going to merge this. |
|
Thanks! Yeah, it's great that there are no labels/project spam all the time for sure :) |
Fixes #33680
Should process template literals in all positions where TS support them. Should correctly return full list when
ts.preProcessFileis called.I also tried to write test like https://github.com/microsoft/TypeScript/blob/98cf317005d62a9b275e1f1b37a18b7f5b457e74/tests/cases/fourslash/shims-pp/getPreProcessedFile.ts
but when I use dynamic imports
I receive 3 errors
Where only 3rd error was expected.
Setting module to
commonjsor target toes2015doesn't help.Do I need to add tests for error reporting on wrong references (3rd error)? Any suggestions how to avoid unexpected errors?