Skip to content

Conversation

@ahejlsberg
Copy link
Member

Fixes the issue reported here: #34840 (comment).

@ahejlsberg ahejlsberg requested a review from weswigham November 8, 2019 19:22
@ahejlsberg ahejlsberg added this to the TypeScript 3.8.0 milestone Nov 8, 2019
@ahejlsberg
Copy link
Member Author

@RyanCavanaugh @weswigham We might consider cherry picking this for 3.7.3.

@weswigham
Copy link
Member

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 8, 2019

Heya @weswigham, I've started to run the extended test suite on this PR at be5d09e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 8, 2019

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at be5d09e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 8, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at be5d09e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User suite diff is same as master and DT failures look unrelated, so seems good.

@RyanCavanaugh
Copy link
Member

@ahejlsberg does this also fix #34960?

@weswigham
Copy link
Member

Based on this exchange in the other PR, I'm guessing yes?

@ahejlsberg
Copy link
Member Author

Yes, this fixes #34960.

@ahejlsberg ahejlsberg merged commit 3a5230a into master Nov 9, 2019
@ahejlsberg ahejlsberg deleted the fewerExhaustivenessChecks branch November 9, 2019 15:52
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants