🤖 Pick PR #38712 (Preserve module marker in es2015+ m...) into release-3.9 #38717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component commits: 1378ebb Preserve module marker in es2015+ module emit for tool compatability
DanielRosenwasser
requested changes
May 21, 2020
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
We need to discuss this - I'm pretty sure at the design meeting, we said no cherry-pick to 3.9
Member
|
I asked @RyanCavanaugh after the fact and he said to... 🤷 |
typescript-bot
added
the
For Uncommitted Bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #38712
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc @weswigham