Skip to content

fix(34934): Completions for private members appear in JavaScript files #38734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jessetrinity merged 1 commit into from
Jun 2, 2020
Merged

fix(34934): Completions for private members appear in JavaScript files #38734

jessetrinity merged 1 commit into from
Jun 2, 2020

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented May 22, 2020

Fixes #34934

orta
orta approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good to me 👍

@jessetrinity jessetrinity merged commit 463f8e1 into microsoft:master Jun 2, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@jessetrinity jessetrinity Awaiting requested review from jessetrinity

+1 more reviewer

@orta orta orta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Completions for private members appear in JavaScript files

4 participants

@a-tarasyuk @orta @sheetalkamat @jessetrinity