Add outlining spans for call expression or arrow body #39109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@typescript-bot pack this. |
Collaborator
Contributor
Author
|
@typescript-bot pack this. |
Collaborator
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
How do constructs "play together" in this case? @jessetrinity
For example, what if you have a multi-line call in a multi-line arrow function? Does Roslyn have to do anything special here @CyrusNajmabadi?
Contributor
Author
|
The play together problem also existed in not only call but also another syntax. For example, multi-line tagged template in a multi-line arrow function. And I don't think we have something to handle them. |
Contributor
|
Nested outlining spans are the normal case (think about a call, inside a method, inside a class, inside a namespace). So it just falls out naturally. |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38597