fix: "Convert named imports to namespace import" adds redundant underscore suffix #44338
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
reviewed
Jun 9, 2021
| const namespaceNameConflicts = toConvert.elements.some(element => | ||
| FindAllReferences.Core.eachSymbolReferenceInFile(element.name, checker, sourceFile, id => | ||
| !!checker.resolveName(preferredName, id, SymbolFlags.All, /*excludeGlobals*/ true)) || false); | ||
| !!checker.resolveName(preferredName, id, SymbolFlags.All, /*excludeGlobals*/ true) && checker.getSymbolAtLocation(element.name) !== checker.getSymbolAtLocation(id)) || false); |
Member
There was a problem hiding this comment.
I don’t immediately understand how checker.getSymbolAtLocation(element.name) !== checker.getSymbolAtLocation(id) could ever be true if id is supposed to be a symbol reference to element.name 🤔 Can you give a brief explanation of how a real naming conflict detection works now that this condition is added?
Member
|
Thanks for your contribution. I investigated the related issue and came up with a fix PR that I think addresses with more special cases (#45019), so I will close this PR now, but we appreciate your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44267