fix(46589): Extra ? added to method in method signature completion for optional method #46594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
a-tarasyuk
force-pushed
the
fix/46589
branch
2 times, most recently
from
6bb521f to
b1f2db7
Compare
gabritto
requested changes
Oct 29, 2021
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
We shouldn't get rid of optional altogether in the codefix helper function, I think that is why there are tests failing on CI. Left a comment with possible solutions.
gabritto
requested changes
Nov 2, 2021
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
I think this is closer to being what we want, just left a comment for one case left to consider. Thanks :)
gabritto
approved these changes
Nov 3, 2021
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
Left a comment for a typo, but I think other than that we're good to go now. Thanks! ✨
Member
|
@typescript-bot cherry-pick this to release-4.5 |
Collaborator
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @andrewbranch, I've opened #46667 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 3, 2021
Component commits: cd33fc8 fix(46589): omit ? in method signature completion for optional methods
DanielRosenwasser
pushed a commit
that referenced
this pull request
Nov 3, 2021
Component commits: cd33fc8 fix(46589): omit ? in method signature completion for optional methods Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46589