Skip to content

Check for type parameters on original type when getting type argument completions #46614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielRosenwasser merged 3 commits into from
Nov 1, 2021
Merged

Check for type parameters on original type when getting type argument completions #46614

DanielRosenwasser merged 3 commits into from
Nov 1, 2021

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Nov 1, 2021

Fixes #32874

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 1, 2021
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Backlog Bug PRs that fix a backlog bug labels Nov 1, 2021
@DanielRosenwasser DanielRosenwasser merged commit 6d33d87 into main Nov 1, 2021
@DanielRosenwasser DanielRosenwasser deleted the stringLiteralTypeArgCompletionFix branch November 1, 2021 18:41
@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Nov 3, 2021

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.5 on this PR at e7c8095. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Nov 3, 2021
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2021

Hey @DanielRosenwasser, I've opened #46675 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 3, 2021
@DanielRosenwasser @typescript-bot
Cherry-pick PR microsoft#46614 into release-4.5
777a9c3 
Component commits:
e77514a Add failing test.

3c0d51b Check for type parameters on the original type when asking for the type argument constraint.

e7c8095 Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts
DanielRosenwasser added a commit that referenced this pull request Nov 3, 2021
@DanielRosenwasser
Cherry-pick PR #46614 into release-4.5 (#46675)
0651bd3 
Component commits:
e77514a Add failing test.

3c0d51b Check for type parameters on the original type when asking for the type argument constraint.

e7c8095 Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@DanielRosenwasser @mprobst
Check for type parameters on original type when getting type argument…
97f1c74 
… completions (microsoft#46614)

* Add failing test.

* Check for type parameters on the original type when asking for the type argument constraint.

* Update tests/cases/fourslash/stringLiteralTypeCompletionsInTypeArgForNonGeneric1.ts
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

@DanielRosenwasser DanielRosenwasser

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property '0' of undefined in 'getTypeArgumentConstraint' during 'completionInfo'

3 participants

@DanielRosenwasser @typescript-bot @andrewbranch