fix(49058): Language service crashes for static member in class with unresolved base members#49059
Merged
sandersn merged 2 commits intomicrosoft:mainfrom May 16, 2022
Merged
Conversation
typescript-bot
added
the
For Milestone Bug
sandersn
approved these changes
May 13, 2022
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I think this is a good fix for the crash. We should correct getExportsOfModule -> getExportsOfSymbol at some point. @DanielRosenwasser do you think we should fix that in this PR?
sandersn
requested changes
May 16, 2022
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Need to resolve the static side of the class differently and use normal property lookup afterwards.
sandersn
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49058