Skip to content

Conversation

@sheetalkamat
Copy link
Member

Changes in this:

  1. tsc --watch stores the package json success locations into affectingLocations on each resolution just like we store failed lookups, this helps in resolving only partial changes as well as not having to do full config file reload which is expensive.
  2. This also adds same thing to tsserver so tsc --watch and tsserver are on same page with respect to package.json changes

This is subset of changes from #48889. This does not include changes to tsc --build that portion can be iterated upon in that PR

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 31, 2022
@sheetalkamat
Copy link
Member Author

Ping @weswigham @andrewbranch can you please review this part. This has nothing to do with build mode and have pulled the build mode changes so we can reflect on design for later.

@sheetalkamat sheetalkamat merged commit 5cedf3e into main Jun 8, 2022
@sheetalkamat sheetalkamat deleted the tscPackageJsonWatch branch June 8, 2022 17:22
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants