Skip to content

Fixed an issue with spreading a spreadable generic expression into generic JSX #51580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weswigham merged 2 commits into from
Mar 15, 2023
Merged

Fixed an issue with spreading a spreadable generic expression into generic JSX #51580

weswigham merged 2 commits into from
Mar 15, 2023
+102 −1

Conversation

@Andarist
Copy link
Contributor

@Andarist Andarist commented Nov 17, 2022

fixes #51577

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 17, 2022
Andarist
Andarist commented Nov 17, 2022
View reviewed changes
src/compiler/checker.ts Outdated
attributesTable = createSymbolTable();
}
const exprType = getReducedType(checkExpressionCached(attributeDecl.expression, checkMode));
const exprType = getReducedType(checkExpressionCached(attributeDecl.expression));
Copy link
Contributor Author

@Andarist Andarist Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this aligns the logic here for the equivalent call in the checkObjectLiteral:
https://github.dev/microsoft/TypeScript/blob/4ea8ec49e8aed6601fb6b978fd08031ec058da04/src/compiler/checker.ts#L28541

note that neither of those lines were touched recently

weswigham
weswigham approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to see some extended suites be green and this looks reasonable to me~

@weswigham
Copy link
Member

weswigham commented Mar 15, 2023

@typescript-bot run dt
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 15, 2023 •
edited
Loading

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 1c00498. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 15, 2023 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 1c00498. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 15, 2023

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/51580/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 15, 2023

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@weswigham weswigham merged commit 63495be into microsoft:main Mar 15, 2023
@jakebailey
Copy link
Member

jakebailey commented Mar 16, 2023

This PR appears to have broken main via a baseline change.

This was referenced Mar 16, 2023
Closed
Merged
jakebailey added a commit to jakebailey/TypeScript that referenced this pull request Mar 16, 2023
@jakebailey
Revert "Fixed an issue with spreading a spreadable generic expression…
e67e273 
… into generic JSX (microsoft#51580)"

This reverts commit 63495be.
jakebailey added a commit that referenced this pull request Mar 16, 2023
@jakebailey
Revert PR #51580 (#53283)
7f292bf
@jakebailey jakebailey mentioned this pull request Mar 16, 2023
Closed
Andarist added a commit to Andarist/TypeScript that referenced this pull request Mar 22, 2023
@Andarist
Revert "Revert PR microsoft#51580 (microsoft#53283)"
a716293 
This reverts commit 7f292bf.
@Andarist Andarist deleted the fix/51577 branch March 22, 2023 23:13
@Andarist Andarist mentioned this pull request Mar 22, 2023
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@weswigham weswigham

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spread of overloaded function rejected on generic components in JSX as of 4.7.4

4 participants

@Andarist @weswigham @typescript-bot @jakebailey