Skip to content

Conversation

@ronyhe
Copy link
Contributor

@ronyhe ronyhe commented Dec 14, 2022

The function returns undefined when the value passed to it is undefined

Fixes #

The function returns undefined when the value passes to it is undefined
@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src/lib' or possibly our lib generator. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src/lib' or https://github.com/microsoft/TypeScript-DOM-lib-generator

@typescript-bot typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug lib update PR modifies files in the `lib` folder labels Dec 14, 2022
@MartinJohns
Copy link
Contributor

MartinJohns commented Dec 14, 2022

#18879

Personally I doubt whether this massive breaking change is really worth it.

@Andarist
Copy link
Contributor

@MartinJohns OTOH, this is really such an easy mistake to make... It's not even like an edge case.

@ronyhe
Copy link
Contributor Author

ronyhe commented Dec 14, 2022

Closing in favor of #51897

@ronyhe ronyhe closed this Dec 14, 2022
@ronyhe
Copy link
Contributor Author

ronyhe commented Dec 14, 2022

#18879

Personally I doubt whether this massive breaking change is really worth it.

Please consider this solution then: #51897

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug lib update PR modifies files in the `lib` folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants