Add missing parameters from Array.toLocaleString on ES2015 libs

[neilbryson]

Fixes #57603

Added on both Array and ReadonlyArray in es2015.core.d.ts

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/toLocaleString

[sandersn]

Couple of questions, plus I need to find out what we need to do legally to use MDN text in Typescript.

[sandersn]

1. Does NumberFormatOptions & DateTimeFormatOptions cover everything? I see that BigInt also has toLocaleString. Could other types have it too?
2. since this adds an overload, locales should not be optional. Otherwise a zero-argument call might resolve to this when it should resolve to the es5 overload.

Suggested change

	toLocaleString(locales?: string | string[], options?: Intl.NumberFormatOptions & Intl.DateTimeFormatOptions): string;
	toLocaleString(locales: string | string[], options?: Intl.NumberFormatOptions & Intl.DateTimeFormatOptions): string;

[neilbryson]

Thanks for the comments!

1. When I checked, it looks like there are only NumberFormatOptions and DateTimeFormatOptions which are accepted by JS in all types with this method (Object, Array, Number, BigInt, TypedArray). BigInt arrays are covered by the current definitions upon testing, but I will still need to update the toLocaleString signature of TypedArrays. I'll send a commit for that

2. I tried not making it optional, but it seems to stop working with single argument calls based on my test run

arrayToLocaleStringES2015.ts(4,11): error TS2575: No overload expects 1 arguments, but overloads do exist that expect either 0 or 2 arguments.
arrayToLocaleStringES2015.ts(10,14): error TS2575: No overload expects 1 arguments, but overloads do exist that expect either 0 or 2 arguments.

I think they should be kept optional, what do you think? In my baselines errors, it was showing the expected behaviour for es5

[sandersn]

1. 👍🏼
2. The error makes it look like both locales and options are both required. But only locales should be required; options should stay optional. When I did a quick local test with a test project using es2015, all 3 calls below worked:

const a = [1,2,3]
a.toLocaleString()
a.toLocaleString('en-US')
a.toLocaleString('en-US', {style: 'currency', currency: 'USD'}) // thanks copilot

[neilbryson]

Hello! I applied the changes to es2015

[sandersn]

Suggested change

	toLocaleString(locales?: string | string[], options?: Intl.NumberFormatOptions & Intl.DateTimeFormatOptions): string;
	toLocaleString(locales: string | string[], options?: Intl.NumberFormatOptions & Intl.DateTimeFormatOptions): string;

[sandersn]

I'd still like locales to be required and options to be optional.

[sandersn]

1. 👍🏼
2. The error makes it look like both locales and options are both required. But only locales should be required; options should stay optional. When I did a quick local test with a test project using es2015, all 3 calls below worked:

const a = [1,2,3]
a.toLocaleString()
a.toLocaleString('en-US')
a.toLocaleString('en-US', {style: 'currency', currency: 'USD'}) // thanks copilot

[sandersn]

Looks good!