-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Write buildInfo even if we dont emit js or dts for --outFile scenarios #58760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0247216 to
79d728f
Compare
…ildInfo even if js file is not emitted
79d728f to
7af031a
Compare
|
@typescript-bot test this |
|
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@sheetalkamat Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Hey @sheetalkamat, the results of running the DT tests are ready. Everything looks the same! |
This comment was marked as spam.
This comment was marked as spam.
|
Uh, why does that perf run look like that? |
|
To me it seems more like a noise. #57196 didnt change anything in compiler and still shows increase in symbols etc |
|
I was referring to the bit where ts-pre-modules stopped compiling, so something's not quite right when when running on that last codebase. |
This makes
--outFilebehave similar to not specifying it.Previously we use to store the bundle section information in the
outFileBuildInfowhich means we could not emit buildInfo without emitting the other output files and had to be always in sync. But now that we are not storing that information with no support forprepend, we can write buildInfo even if the other outputs like js or dts were not emitted. This helps with storing semantic diagnostics information and dts errors information in the buildInfo so we can re-use it just like multiFile scenario.The changes are:
--outFilescenario