Skip ID inference errors on nodes collected from other files #59203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
approved these changes
Jul 9, 2024
Member
|
@typescript-bot cherry-pick this to release-5.5 |
Collaborator
Member
|
I think this is marked for 5.6, but this is such a simple change and we're already fixing a bunch of ID related stuff in the next patch. |
Collaborator
|
Hey, @jakebailey! I've created #59210 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jul 16, 2024
…e-5.5 (#59210) Co-authored-by: Wesley Wigham <wwigham@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58909
I considered skipping the error at the callsite issuing the error if the node isn't from the
context.enclosingFile, but remembering that at every callsite is much more cumbersome than just filtering the node's applicability for the output file under consideration within the error reporter itself.