Use local symbol rather then target symbol for tracking reused references #59493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
weswigham
changed the title
jakebailey
approved these changes
Jul 31, 2024
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Aha, nice; theoretically I think we want this for another 5.5 patch if we're doing one.
Member
|
@typescript-bot cherry-pick this to release-5.5 |
Collaborator
typescript-bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Collaborator
|
Hey, @jakebailey! I've created #59502 for you. |
Member
|
Was the original issue actually a 5.5 regression? |
Member
|
Yes, the regressing PR was #57887 |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Aug 8, 2024
…e-5.5 (#59502) Co-authored-by: Wesley Wigham <wewigham@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59470
When we started reusing the node from the target file (since it refers to the same thing as the local name), we accidentally stopped marking the local reference to that thing as used for the output. By swapping which symbol we track to the local version, we ensure we track the references we need to keep in the output.