Skip to content

Don't set parent on non-transient symbols in mergeSymbolTable #61560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 2 commits into from
Dec 4, 2025
Merged

Don't set parent on non-transient symbols in mergeSymbolTable #61560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0efb559
Don't set parent on non-transient symbols in mergeSymbolTable
jakebailey Apr 9, 2025
e2105d5
Merge branch 'main' into transient-symbol-merge
jakebailey Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2834,7 +2834,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
// When merging the module augmentation into a.ts, the symbol for `A` will itself be merged, so its parent
// should be the merged module symbol. But the symbol for `B` has only one declaration, so its parent should
// be the module augmentation symbol, which contains its only declaration.
merged.parent = mergedParent;
if (merged.flags & SymbolFlags.Transient) {
merged.parent = mergedParent;
}
}
target.set(id, merged);
});
Expand Down
Loading